Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Fix/14904 EOL - "Mehr" area has unnecessary line / space in the end #5079

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Fix/14904 EOL - "Mehr" area has unnecessary line / space in the end #5079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8c4616
14904: `MoreActionItemView` is now configurable to hide separator view.
flxschmidt Mar 10, 2023
5775bb3
14904: `MoreActionItemView` is now configurable to hide separator view.
flxschmidt Mar 10, 2023
8d249e6
14904: Remove unused code.
flxschmidt Mar 10, 2023
a71e6d5
Merge branch 'story/14427-ramp-down-cwa' into fix/14904-EOL-Mehr-area…
flxschmidt Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/xcode/ENA/ENA/Source/Scenes/Home/Cells/More/HomeMoreInfoTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ class HomeMoreInfoTableViewCell: UITableViewCell {
let nib = UINib(nibName: nibName, bundle: .main)

if let actionItemView = nib.instantiate(withOwner: self, options: nil).first as? MoreActionItemView {
actionItemView.configure(actionItem: item) { selectedItem in
actionItemView.configure(
actionItem: item,
hideSeparatorView: item == items.last
) { selectedItem in
onItemTap(selectedItem)
}
stackView.addArrangedSubview(actionItemView)
Expand Down
3 changes: 2 additions & 1 deletion src/xcode/ENA/ENA/Source/Scenes/Home/Cells/More/MoreActionItem/MoreActionItemView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class MoreActionItemView: UIView {

func configure(
actionItem: MoreInfoItem,
hideSeparatorView: Bool = false,
completion: @escaping ((MoreInfoItem) -> Void)
) {
imageView.image = actionItem.image
Expand All @@ -31,7 +32,7 @@ class MoreActionItemView: UIView {
accessibilityIdentifier = actionItem.accessibilityIdentifier
accessibilityLabel = actionItem.title

separatorView.isHidden = actionItem == .share
separatorView.isHidden = hideSeparatorView

self.actionItem = actionItem
self.completion = completion
Expand Down