Core: Fixes for Display Color Sample #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2023
scottrules44
force-pushed
the
fixForColorSample
branch
from
4266be2 to
8ce1bd8
Compare
Shchvova
approved these changes
May 23, 2023
pouwelsjochem
added a commit
to pouwelsjochem/solar2d
that referenced
this pull request
Oct 11, 2023
pouwelsjochem
added a commit
to pouwelsjochem/solar2d
that referenced
this pull request
Oct 11, 2023
This reverts commit 7f12aae.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to run "ContentToScreen" with color output because w and h are 1 those could be rounded down to 0 on certain screen sizes.
I also noticed the same crash as with display.capture() some times, rerendering after call seems to fix the issue. Can remove that piece if needed