[feat]: add the ability to filter by group when fetching merge requests paginated #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,8 @@ public List<MergeRequest> getMergeRequests(MergeRequestFilter filter, int page, | |||
| } | |||
|
|
|||
| response = get(Response.Status.OK, queryParams, "projects", filter.getProjectId(), "merge_requests"); | |||
| } else if (filter != null && filter.getGroupId() != null && filter.getGroupId().intValue() > 0) { | |||
There was a problem hiding this comment.
I'm confused, is there a reason this list merge requests endpoint with page number and page size doesn't support the group id but the one with pager does support the group id path?
Is there a way to test that this works since we're branching the API code?
jennie-m-chen
approved these changes
Aug 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
We want the ability to add a group ID filter to the paginated merge request API that fetches merge requests using page number and page size.
Type of change
Checklists
Development
Security
Code review