tests/base_test.py: Use __name__ for Flask's import_name #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid several test failures like:
======================================================================
ERROR: test_credentialed_request (tests.test_credentials.AppConfigExposeHeadersTestCase)
AppConfigExposeHeadersTestCase.test_credentialed_request
----------------------------------------------------------------------
Traceback (most recent call last):
File "/.../tests/base_test.py", line 82, in setUp
self.app = Flask(self.__class__.__name__)
File "/usr/lib64/python3.4/site-packages/flask/app.py", line 319, in __init__
template_folder=template_folder)
File "/usr/lib64/python3.4/site-packages/flask/helpers.py", line 741, in __init__
self.root_path = get_root_path(self.import_name)
File "/usr/lib64/python3.4/site-packages/flask/helpers.py", line 631, in get_root_path
loader = pkgutil.get_loader(import_name)
File "/usr/lib64/python3.4/pkgutil.py", line 469, in get_loader
return find_loader(fullname)
File "/usr/lib64/python3.4/pkgutil.py", line 490, in find_loader
return spec.loader
AttributeError: 'NoneType' object has no attribute 'loader'
on Python 3.4 [1]. The solution is to use an importable name [2]:
> About the First Parameter
>
> The idea of the first parameter is to give Flask an idea what
> belongs to your application. This name is used to find resources on
> the file system, can be used by extensions to improve debugging
> information and a lot more.
>
> So it’s important what you provide there. If you are using a single
> module, __name__ is always the correct value. If you however are
> using a package, it’s usually recommended to hardcode the name of
> your package there.
Previously we were using the class name (not the module name), but you
can't use that to import anything ;).
[1]: pallets/flask#1011
[2]: http://flask.pocoo.org/docs/0.10/api/#flask.Flask
|
Great!, looks good to me. I'll cut a patch release tonight. |
|
thanks, mate |
corydolphin
pushed a commit
that referenced
this pull request
Sep 19, 2014
tests/base_test.py: Use __name__ for Flask's import_name
|
Just to close the loop, I had a few changes pending and wrapped them in for a dot release. Shipped 1.9.0 earlier this morning. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid several test failures like:
on Python 3.4 1. The solution is to use an importable name 2:
Previously we were using the class name (not the module name), but you
can't use that to import anything ;).