Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Start to implement photo-meson interactions #149

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

cosimoNigro
Copy link
Owner

@IlariaViale, @dimaniad6, let us use this branch to work on the implementation of the photomeson interactions.
We are following the analytical parametrisation of Kelner Aharonian 2008 (https://arxiv.org/abs/0803.0688).

cosimoNigro and others added 2 commits July 5, 2023 16:21
…s from Kelner Aharonian 2008 for each product particle and the kernels.py file for the integration of the photo-meson production
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (c268fa8) 97.02% compared to head (256fe4a) 95.39%.

❗ Current head 256fe4a differs from pull request most recent head a11cec2. Consider uploading reports for the commit a11cec2 to get more accurate results

Files Patch % Lines
agnpy/photo_meson/kernels.py 25.31% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   97.02%   95.39%   -1.63%     
==========================================
  Files          43       45       +2     
  Lines        3394     3474      +80     
==========================================
+ Hits         3293     3314      +21     
- Misses        101      160      +59     
Flag Coverage Δ
unittests 95.39% <26.25%> (-1.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosimoNigro
Copy link
Owner Author

Hello @dimaniad6, @IlariaViale, do you think you will have some time in the next days to work on this?

@cosimoNigro
Copy link
Owner Author

Thanks for the updates @dimaniad6, @IlariaViale, I did not mean to rush you.

By the way, when you reply to GitHub notifications via mail your reply is also posted on GitHub 😄, I am removing your replies since they contain personal informations.

Repository owner deleted a comment from dimaniad6 Sep 4, 2023
Repository owner deleted a comment from IlariaViale Sep 4, 2023
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants