Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

baseapp: do we need to store the header? #522

Closed
ebuchman opened this issue Feb 28, 2018 · 1 comment
Closed

baseapp: do we need to store the header? #522

ebuchman opened this issue Feb 28, 2018 · 1 comment
Assignees

Comments

@ebuchman
Copy link
Member

ebuchman commented Feb 28, 2018

See the comment here: https://github.com/cosmos/cosmos-sdk/pull/521/files#diff-1a66280186fb23f75ab1d32920d81a1fR139

If not, we can clean up all that commented stuff and related logic in baseapp.

If so, either the AppHash will change with every block or we need to do surgery on the store interfaces to allow the header to be written to the db atomically with the other info.

Also, if we want the AppHash to not change every block, we need to deal with #520

@ValarDragon
Copy link
Contributor

Closing per conversation that we don't need it. We haven't had a need for it in the last few months, and the header is already provided in begin blocker for applications.

MSalopek pushed a commit to MSalopek/cosmos-sdk that referenced this issue Feb 22, 2024
* fix halt height edge case

* lints

(cherry picked from commit 621ca69)

Co-authored-by: Adam Tucker <adam@osmosis.team>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants