Events are accumulating in msg.sender across trs

[zmanian]

We are observing the the Events emitted by the antehandler in #6187 get persisted between transactions.

So the first first tx in a block has 1 sender, the 2nd has two senders etc.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[fedekunze]

@zmanian can you paste a concrete example to see the transactions involved?

[alexanderbez]

diff --git a/baseapp/baseapp.go b/baseapp/baseapp.go
index e9d0d2baa..22747e80f 100644
--- a/baseapp/baseapp.go
+++ b/baseapp/baseapp.go
@@ -551,6 +551,7 @@ func (app *BaseApp) runTx(mode runTxMode, txBytes []byte, tx sdk.Tx) (gInfo sdk.
                // writes do not happen if aborted/failed.  This may have some
                // performance benefits, but it'll be more difficult to get right.
                anteCtx, msCache = app.cacheTxContext(ctx, txBytes)
+               anteCtx = anteCtx.WithEventManager(sdk.NewEventManager())
                newCtx, err := app.anteHandler(anteCtx, tx, mode == runTxModeSimulate)
 
                if !newCtx.IsZero() {

[zmanian]

Here are some sagan logs of the observed behavior

https://gist.github.com/zmanian/7af457882b7fdd992af5be747ac8c208

[Codegnosis]

Hi - we have noticed this occurring in SDK v0.38.3 too. Will the v0.38 SDK release branch be updated with this fix?