Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Replace testify with gotest.tools in distribution integration tests #14495

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #14494
ref: #14145 #12332


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-prbot github-prbot requested review from a team, aaronc and facundomedica and removed request for a team January 5, 2023 08:20
@likhita-809 likhita-809 marked this pull request as ready for review January 5, 2023 08:51
@likhita-809 likhita-809 requested a review from a team as a code owner January 5, 2023 08:51
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, few nits

@julienrbrt julienrbrt enabled auto-merge (squash) January 5, 2023 09:31
@julienrbrt julienrbrt disabled auto-merge January 5, 2023 09:38
@julienrbrt julienrbrt enabled auto-merge (squash) January 5, 2023 10:47
@julienrbrt julienrbrt merged commit fcd544f into main Jan 5, 2023
@julienrbrt julienrbrt deleted the likhita/replace-testify-distr-integration-tests branch January 5, 2023 11:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace testify with gotest.tools in in integration/distribution tests
2 participants