Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test(x/circuit): add MsgAuthorizeCircuitBreaker feature #14512

Merged
merged 24 commits into from
Jan 12, 2023
Merged

test(x/circuit): add MsgAuthorizeCircuitBreaker feature #14512

merged 24 commits into from
Jan 12, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jan 5, 2023 •
edited
Loading

Description

Ref #14226

Adds the first Gherkin BDD feature file as a starting point example plus (skipped) failing stub tests.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-prbot github-prbot requested review from a team, likhita-809 and testinginprod and removed request for a team January 5, 2023 19:04
@aaronc aaronc marked this pull request as ready for review January 5, 2023 19:22
@aaronc aaronc requested a review from a team as a code owner January 5, 2023 19:22
@alexanderbez alexanderbez marked this pull request as draft January 5, 2023 20:17
@aaronc aaronc marked this pull request as ready for review January 5, 2023 20:54
likhita-809
likhita-809 reviewed Jan 9, 2023
View reviewed changes
@likhita-809 likhita-809 changed the title tests(x/circuit): add MsgAuthorizeCircuitBreaker feature test(x/circuit): add MsgAuthorizeCircuitBreaker feature Jan 9, 2023
aaronc and others added 6 commits January 11, 2023 11:37
@aaronc @likhita-809
Update x/circuit/features/msg_authorize.feature
2037b81 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@aaronc @likhita-809
Update x/circuit/features/msg_authorize.feature
0c6fefe 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@aaronc @likhita-809
Update x/circuit/features/msg_authorize.feature
fa6bba1 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@aaronc
fix test case
7df4750
@aaronc
Merge branch 'main' of github.com:cosmos/cosmos-sdk into aaronc/circu…
d880519 
…it-bdd-intro
@aaronc
proto gen
bfcf8da
@sonarqubecloud
Copy link

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

julienrbrt
julienrbrt reviewed Jan 12, 2023
View reviewed changes
tac0turtle and others added 4 commits January 12, 2023 14:02
@tac0turtle
Merge branch 'main' into aaronc/circuit-bdd-intro
f1c72e7
@tac0turtle
remove go.mod
4c48944
@tac0turtle @likhita-809
Apply suggestions from code review
40f32eb 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
@tac0turtle
address comments
6dfd88b
@tac0turtle tac0turtle enabled auto-merge (squash) January 12, 2023 13:43
@tac0turtle tac0turtle disabled auto-merge January 12, 2023 13:43
@tac0turtle tac0turtle enabled auto-merge (squash) January 12, 2023 15:51
@tac0turtle tac0turtle merged commit 248f8bd into main Jan 12, 2023
@tac0turtle tac0turtle deleted the aaronc/circuit-bdd-intro branch January 12, 2023 19:14
@julienrbrt julienrbrt mentioned this pull request Jan 13, 2023
Merged
19 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@julienrbrt julienrbrt julienrbrt left review comments

@likhita-809 likhita-809 likhita-809 left review comments

@08d2 08d2 08d2 left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@testinginprod testinginprod Awaiting requested review from testinginprod

Assignees

@samricotta samricotta

@likhita-809 likhita-809

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aaronc @alexanderbez @tac0turtle @julienrbrt @likhita-809 @08d2 @samricotta