Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: Comet v0.38 Integration #15519

Merged
merged 97 commits into from
May 24, 2023
Merged

feat!: Comet v0.38 Integration #15519

merged 97 commits into from
May 24, 2023

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 22, 2023

Description

This PR acts as the base feature PR for Comet v0.38 integration into the SDK. Primarily, it contains the following:

  • Update of go.mod deps
  • Updates to existing ABCI methods in abci.go
  • A (partial) implementation of FinalizeBlock

Subsequent PRs should be based off of this branch and use this branch as the base branch when creating PRs.

ref: #12272


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review April 6, 2023 13:40
@alexanderbez alexanderbez requested a review from a team as a code owner April 6, 2023 13:40
@github-prbot github-prbot requested review from a team, mark-rushakoff and JeancarloBarrios and removed request for a team April 6, 2023 13:40
@github-actions github-actions bot removed C:x/crisis C:Hubl Tool: Hubl Type: CI C:Confix Issues and PR related to Confix C:x/mint C:log C:Cosmovisor Issues and PR related to Cosmovisor C:collections C:orm labels May 24, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

tac0turtle and others added 2 commits May 24, 2023 15:43
@tac0turtle tac0turtle enabled auto-merge May 24, 2023 15:54
@tac0turtle tac0turtle added this pull request to the merge queue May 24, 2023
Merged via the queue into main with commit 6cee22d May 24, 2023
@tac0turtle tac0turtle deleted the bez/feature/abci-2.0-base branch May 24, 2023 16:11
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants