Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: skip fix registration for linting #15965

Merged
merged 2 commits into from
Apr 27, 2023
Merged

ci: skip fix registration for linting #15965

merged 2 commits into from
Apr 27, 2023

Conversation

julienrbrt
Copy link
Member

Description

Skips the fix_regsitration.go from golangci-lint.
This isn't the first time golangci-lint has been flaky on it, which isn't handy when our linter job is required.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner April 26, 2023 21:18
@github-prbot github-prbot requested review from a team, aaronc and JeancarloBarrios and removed request for a team April 26, 2023 21:18
@tac0turtle tac0turtle added this pull request to the merge queue Apr 27, 2023
Merged via the queue into main with commit a6ea094 Apr 27, 2023
@tac0turtle tac0turtle deleted the julien/golangci branch April 27, 2023 05:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants