Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test(x/evidence): write integration tests #16015

Merged
merged 15 commits into from
May 4, 2023
Merged

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented May 3, 2023

ref: #14145

This PR refactors the evidence integration tests to use new testing framework setup and removes duplicate code


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 changed the title Likhita/evidence tests tests(x/evidene): write integration tests May 3, 2023
@likhita-809 likhita-809 changed the title tests(x/evidene): write integration tests tests(x/evidence): write integration tests May 3, 2023
@likhita-809 likhita-809 changed the title tests(x/evidence): write integration tests test(x/evidence): write integration tests May 3, 2023
@likhita-809 likhita-809 marked this pull request as ready for review May 3, 2023 13:06
@likhita-809 likhita-809 requested a review from a team as a code owner May 3, 2023 13:06
@github-prbot github-prbot requested review from a team, aaronc and atheeshp and removed request for a team May 3, 2023 13:07
@julienrbrt julienrbrt self-assigned this May 3, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending conflicts.

@julienrbrt julienrbrt added this pull request to the merge queue May 4, 2023
Merged via the queue into main with commit 34018f7 May 4, 2023
@julienrbrt julienrbrt deleted the likhita/evidence-tests branch May 4, 2023 17:26
@likhita-809 likhita-809 mentioned this pull request May 22, 2023
42 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants