fix(slashing): slashing test failures #16116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool-develope
changed the title
cool-develope
commented
May 11, 2023
| @@ -148,7 +148,7 @@ func SignCheckDeliver( | |||
| if finalizeSuccess { | |||
| err = nil | |||
| } else { | |||
| err = fmt.Errorf(txResult.Log) | |||
| err = errors.ABCIError(txResult.Codespace, txResult.Code, txResult.Log) | |||
There was a problem hiding this comment.
This change may not be reasonable, but the slashing test requires a more exact error type.
cc: @kocubinski @alexanderbez @tac0turtle
There was a problem hiding this comment.
I also think @kocubinski also changed these files
There was a problem hiding this comment.
I guess you can try to see if this breaks other usages of SignCheckDeliver?
There was a problem hiding this comment.
it is used in bank, staking and slashing, I confirmed it doesn't break anything
alexanderbez
approved these changes
May 15, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #12272
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change