Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

keys: Keybase.Update no longer asks for newpass if oldpass is incorrect #1631

Merged
merged 2 commits into from
Jul 12, 2018
Merged

keys: Keybase.Update no longer asks for newpass if oldpass is incorrect #1631

merged 2 commits into from
Jul 12, 2018

Conversation

ValarDragon
Copy link
Contributor

Achieved by refactoring the parameter newpass as follows:

  • (newpass string) -> (getNewpass func() (string, error))

Closes #1629

  • Updated all relevant documentation in docs - updated godoc
  • Updated all code comments where relevant - updated godoc
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)

@ValarDragon ValarDragon requested a review from cwgoes July 11, 2018 02:58
@ValarDragon
keys: Keybase.Update no longer asks for newpass if oldpass is incorrect
fc4c563 
Achieved by refactoring the parameter newpass as follows:

* (newpass string) -> (getNewpass func() (string, error))

Closes #1629
@ValarDragon ValarDragon force-pushed the dev/fix_key_update_bug branch from aa3bd00 to fc4c563 Compare July 11, 2018 03:00
@ValarDragon
Copy link
Contributor Author

ValarDragon commented Jul 11, 2018 •
edited
Loading

We should be able to merge this one before next testnet, as it doesn't break the state / isn't a feature add. Just fixes a UI bug, and breaks SDK API.

@ValarDragon
Copy link
Contributor Author

I think the Cli failure here is non-deterministic, could not replicate on my machine.

@codecov
Copy link

codecov bot commented Jul 11, 2018 •
edited
Loading

Codecov Report

Merging #1631 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1631   +/-   ##
=======================================
  Coverage   63.78%   63.78%           
=======================================
  Files         122      122           
  Lines        6763     6763           
=======================================
  Hits         4314     4314           
  Misses       2204     2204           
  Partials      245      245

@ValarDragon
Copy link
Contributor Author

Re-ran test_cli via ssh and it passed. (Now just waiting 10 minutes for that ssh session to close)

cwgoes
cwgoes approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit e9db4a8 into master Jul 12, 2018
@cwgoes cwgoes deleted the dev/fix_key_update_bug branch July 12, 2018 17:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @cwgoes