Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

baseapp: Allow alphanumerics in routes #1705

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Conversation

ValarDragon
Copy link
Contributor

Previously only alphabetic characters were allowed.

Closes #1587

  • Updated all relevant documentation (docs/) - current docs are correct
  • Updated all relevant code comments
  • Wrote tests - numeric usage is already covered in a test vector
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Previously only alphabetic characters were allowed.

Closes #1587
@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #1705 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop    #1705   +/-   ##
========================================
  Coverage    62.35%   62.35%           
========================================
  Files          120      120           
  Lines         7119     7119           
========================================
  Hits          4439     4439           
  Misses        2429     2429           
  Partials       251      251

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit f88d644 into develop Jul 17, 2018
@cwgoes cwgoes deleted the dev/allow_alphanumerics branch July 17, 2018 21:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants