Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Openbsd support #1989

Merged
merged 3 commits into from
Aug 14, 2018
Merged

Openbsd support #1989

merged 3 commits into from
Aug 14, 2018

Conversation

avis
Copy link
Contributor

@avis avis commented Aug 12, 2018

@ValarDragon

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@avis avis mentioned this pull request Aug 12, 2018
4 tasks
@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

Merging #1989 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1989      +/-   ##
===========================================
+ Coverage    64.86%   64.86%   +<.01%     
===========================================
  Files          115      114       -1     
  Lines         6862     6837      -25     
===========================================
- Hits          4451     4435      -16     
+ Misses        2127     2120       -7     
+ Partials       284      282       -2

Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, Thanks for fixing this, much appreciated :)

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, thanks

@cwgoes cwgoes merged commit 0adbd60 into cosmos:develop Aug 14, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants