Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update to amino 0.14.1 #2796

Merged
merged 2 commits into from
Nov 13, 2018
Merged

update to amino 0.14.1 #2796

merged 2 commits into from
Nov 13, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Nov 13, 2018

  • same as update to amino 0.14.1 tendermint/tendermint#2822

  • the amino update fixes an overflowing int issue that is preventing builds on 32 bit platforms

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #2796 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2796   +/-   ##
========================================
  Coverage    56.77%   56.77%           
========================================
  Files          156      156           
  Lines         9814     9814           
========================================
  Hits          5572     5572           
  Misses        3863     3863           
  Partials       379      379

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☕️

@cwgoes
Copy link
Contributor

cwgoes commented Nov 13, 2018

Needs a PENDING.md entry.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit d184121 into develop Nov 13, 2018
@cwgoes cwgoes deleted the zach/amino-arm branch November 13, 2018 22:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants