-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
R4R: added macos integration tests #3152
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3152 +/- ##
===========================================
- Coverage 55.03% 55.01% -0.02%
===========================================
Files 133 133
Lines 9427 9434 +7
===========================================
+ Hits 5188 5190 +2
- Misses 3922 3927 +5
Partials 317 317 |
d47c7dd
to
f6eb808
Compare
Only running the basic integration test and fast simulation, can add more if required. I think we should also only run this on develop and master branch as we have a limited amount of minutes for macos testing right now. I haven't implemented that filtering as of yet, but it's a simple change. |
Changed my mind, added branch filtering from the get go. Successful tests of the macos ci can be found here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just want to test that the binary compiles on mac, which this does. Not against also running basic tests on mac too, but this looks good.
Great. I removed the examples tests. I'm leaving the integration and fast sim for sanity 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mo tests, mo betta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, great to test this now - thanks @mircea-c!
Closes #2498
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: