Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Change swagger host for online API requests #3229

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

fedekunze
Copy link
Collaborator

Closes #2948

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #3229 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3229      +/-   ##
===========================================
- Coverage    54.86%   54.85%   -0.02%     
===========================================
  Files          133      133              
  Lines         9554     9556       +2     
===========================================
  Hits          5242     5242              
- Misses        3990     3992       +2     
  Partials       322      322

@jackzampolin
Copy link
Member

I don't know if we want to expose a service on a domain not controlled by the company for this. cc @greg-szabo @mircea-c

@fedekunze
Copy link
Collaborator Author

I can change it to the voyager node, would that be better ?

@jackzampolin
Copy link
Member

That would be better...

@mircea-c
Copy link

mircea-c commented Jan 4, 2019

We should not expose a service on a URL we don't control. That would fail any security audit.

Voyager node works.

@alexanderbez
Copy link
Contributor

alexanderbez commented Jan 4, 2019

@mircea-c do you have a specific host we can use or does fabo.interblock.io work?

@mircea-c
Copy link

mircea-c commented Jan 4, 2019

@alexanderbez that host is the Voyager node. It works for me 😸

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackzampolin jackzampolin merged commit 966baa5 into develop Jan 4, 2019
@jackzampolin jackzampolin deleted the fedekunze/2948-swagger-baseURL branch January 4, 2019 21:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants