Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Introduce RESTful error responses #3485

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 2, 2019

Make error responses turn into JSON responses.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #3485 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #3485      +/-   ##
==========================================
- Coverage    59.42%   59.4%   -0.03%     
==========================================
  Files          130     130              
  Lines         9804    9804              
==========================================
- Hits          5826    5824       -2     
- Misses        3608    3610       +2     
  Partials       370     370

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- left a minor comment that should be addressed before approval.

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit 2e4fa26 into develop Feb 4, 2019
@cwgoes cwgoes deleted the alessio/rest-error-responses branch February 4, 2019 04:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants