Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Indicate build flags in version #3620

Merged
merged 6 commits into from
Feb 13, 2019
Merged

Conversation

jleni
Copy link
Member

@jleni jleni commented Feb 12, 2019

This PR adds build tags to the version command:

cosmos-sdk: 0.31.1-10-gfe548c08
git commit: fe548c0
vendor hash: 1aec7edfad9888a967b3e9063e42f66b28f447e6
build tags: netgo ledger
go version go1.11.5 linux/amd64

This is useful to understand which features were enabled when building the binary.
The issue is related to #3528

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

  • Wrote tests


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jleni jleni changed the title WIP: Indicate build flags in version R4R: Indicate build flags in version Feb 12, 2019
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jleni
Copy link
Member Author

jleni commented Feb 12, 2019

rebased, it should build correctly now

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could also use a description of which build tags are available and what functionality is enabled by each. Maybe as a note in /docs/gaia/installation.md?

@jleni
Copy link
Member Author

jleni commented Feb 13, 2019

This could also use a description of which build tags are available and what functionality is enabled by each. Maybe as a note in /docs/gaia/installation.md?

At the moment, the Makefile does not allow passing tags. Users would have to hack the Makefile.
Nevertheless, I will document what the tags mean in the version command output.

@jleni jleni force-pushed the buildtags branch 2 times, most recently from 4f25bce to 84a3540 Compare February 13, 2019 06:21
@alessio
Copy link
Contributor

alessio commented Feb 13, 2019

@jleni dixit:

At the moment, the Makefile does not allow passing tags. Users would have to hack the Makefile.
Nevertheless, I will document what the tags mean in the version command output.

That's doable, I can deal with it.

@jackzampolin jackzampolin merged commit 787f465 into cosmos:develop Feb 13, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants