Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R: Uint overhaul #3665

Merged
merged 5 commits into from
Feb 19, 2019
Merged

R4R: Uint overhaul #3665

merged 5 commits into from
Feb 19, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 16, 2019

  • Safe implementation:
    • Ops return values are guaranteed greater-than-or-equal-0.
    • Constructors fail if supplied input is < 0.
  • Remove dead code (e.g. NewUintWithDecimal, unused).
  • Comprehensive test suite.

This work is done in preparation for migrating away from Int once and for all.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added the core label Feb 16, 2019
@alessio alessio changed the title Uint overhaul R4R: Uint overhaul Feb 16, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #3665 into develop will decrease coverage by 0.63%.
The diff coverage is 90%.

@@             Coverage Diff             @@
##           develop    #3665      +/-   ##
===========================================
- Coverage    61.22%   60.58%   -0.64%     
===========================================
  Files          189      190       +1     
  Lines        14039    14191     +152     
===========================================
+ Hits          8595     8598       +3     
- Misses        4902     5054     +152     
+ Partials       542      539       -3

@jleni
Copy link
Member

jleni commented Feb 19, 2019

The 030303 issue hit you :|

@jackzampolin jackzampolin merged commit b67d024 into develop Feb 19, 2019
@cwgoes cwgoes deleted the alessio/safe-uint branch February 20, 2019 02:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants