Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use from instead of name CLI flag for the tx sign cmd #3713

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Feb 22, 2019

closes: #3711


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #3713 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3713   +/-   ##
========================================
  Coverage    61.15%   61.15%           
========================================
  Files          190      190           
  Lines        14008    14008           
========================================
  Hits          8567     8567           
  Misses        4905     4905           
  Partials       536      536

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cwgoes cwgoes merged commit c96d8f3 into develop Feb 22, 2019
@cwgoes cwgoes deleted the bez/3711-update-sign-cli-flag branch February 22, 2019 16:15
@alessio
Copy link
Contributor

alessio commented Mar 1, 2019

This should be an argument, not a flag.

@cwgoes
Copy link
Contributor

cwgoes commented Mar 2, 2019

This should be an argument, not a flag.

Maybe, I think it's nice to be explicit for key names though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gaiacli tx sign uses outdated flag "name" instead of "from"
3 participants