Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updating upstream dependencies #4345

Merged
merged 2 commits into from
May 16, 2019
Merged

Updating upstream dependencies #4345

merged 2 commits into from
May 16, 2019

Conversation

jleni
Copy link
Member

@jleni jleni commented May 16, 2019 •
edited
Loading

There have been reports of Nano X detection issues in gaiacli.
This PR fixes the problem by upgrading upstream dependencies.

Related PRs:
cosmos/ledger-cosmos-go#8
cosmos/ledger-go#2

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jleni jleni marked this pull request as ready for review May 16, 2019 14:48
alexanderbez
alexanderbez approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit e09ebf9 into cosmos:master May 16, 2019
alexanderbez pushed a commit that referenced this pull request May 23, 2019
@jleni @alexanderbez
Cherry Pick PR #4345: Upgrade ledger-cosmos-go
68f45db
@alexanderbez alexanderbez mentioned this pull request May 23, 2019
Merged
5 tasks
alexanderbez added a commit that referenced this pull request May 23, 2019
@alexanderbez
Merge PR #4400: Release v0.34.5 - RC1
c7c8bbd 
* Cherry Pick PR #4345: Upgrade ledger-cosmos-go

* Cherry Pick PR #4336: Fix AppendTags usage error

* Update modules

* Cherry Pick PR #4265: CacheKVStore keep sorted items

* Cherry Pick #4227: Adding support for Ledger Cosmos App v1.5

* Cherry Pick #4395: Improve sig verification error message

* Cherry Pick PR #4140: Fix Failed Simulation Seeds
@rllola rllola deleted the nanox branch November 21, 2022 13:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@alessio alessio Awaiting requested review from alessio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jleni @alexanderbez @jackzampolin @rigelrozanski