Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix and Return Height in x/distribution REST Handlers #5508

Merged
merged 9 commits into from
Jan 10, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 10, 2020

Fix and return height in the following x/distribution REST handlers:

  • /distribution/validators/{validatorAddr}/rewards
  • /distribution/validators/{validatorAddr}
  • /distribution/delegators/{delegatorAddr}/rewards/{validatorAddr}
  • /distribution/delegators/{delegatorAddr}/rewards

closes: #5504


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added WIP C:x/distribution distribution module related labels Jan 10, 2020
@alexanderbez alexanderbez changed the base branch from bez/5504-fix-distr-routes to master January 10, 2020 20:08
@alexanderbez alexanderbez marked this pull request as ready for review January 10, 2020 20:44
@alexanderbez alexanderbez added R4R and removed WIP labels Jan 10, 2020
@alexanderbez alexanderbez merged commit 2140244 into master Jan 10, 2020
@alexanderbez alexanderbez deleted the bez/5504-fix-distr-routes-ii branch January 10, 2020 21:10
@alexanderbez alexanderbez mentioned this pull request Feb 28, 2020
10 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Height Missing in Some x/distribution Routes
2 participants