Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: test for x/simulation/operations.go #5582

Closed
wants to merge 2 commits into from

Conversation

githubsands
Copy link

@githubsands githubsands commented Jan 29, 2020

#5007

Unit tests for operations.go and some changes within it.

This PR is to be broken up into 3 commits:

(1) func NewOperationEntry() changes
(2) func queuedOperations() algorithm refactor
(3) unit tests

To do:

  • edit test to use testify as asked in code of conduct
  • refactor sorting algorithm within func queuedOperations
  • finish tests

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@githubsands githubsands changed the title [WIP] test for operations.go WIP: test for operations.go Jan 29, 2020
@githubsands githubsands changed the title WIP: test for operations.go WIP: test for x/simulation/operations.go Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #5582 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5582   +/-   ##
=======================================
  Coverage   54.21%   54.21%           
=======================================
  Files         313      313           
  Lines       18974    18974           
=======================================
  Hits        10287    10287           
  Misses       7887     7887           
  Partials      800      800           

@stale
Copy link

stale bot commented Mar 6, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 6, 2020
@stale stale bot closed this Mar 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant