Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build with Go 1.14 #5719

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Build with Go 1.14 #5719

merged 1 commit into from
Feb 28, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 28, 2020


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio marked this pull request as ready for review February 28, 2020 11:02
@alessio alessio added the R4R label Feb 28, 2020
@@ -3,7 +3,7 @@ version: 2.1
executors:
golang:
docker:
- image: circleci/golang:1.13
- image: circleci/golang:1.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why specify a version? docker grabs latest build

Copy link
Contributor

@jgimeno jgimeno Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a good approach to set controlled version, and update by hand to check if it works. I saw lots of places not recommended to use latest by default.

In summary you control when to update instead of the maintainers of the go image. :P

@alessio alessio merged commit 66f8e35 into master Feb 28, 2020
@alessio alessio deleted the alessio/go-1.14 branch February 28, 2020 12:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants