Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix IncrementSequenceDecorator #5950

Merged
merged 4 commits into from
Apr 7, 2020
Merged

Fix IncrementSequenceDecorator #5950

merged 4 commits into from
Apr 7, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 7, 2020

replaces: #5905
credit: @mjackson001


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #5950 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5950   +/-   ##
=======================================
  Coverage   56.48%   56.48%           
=======================================
  Files         342      342           
  Lines       20270    20270           
=======================================
  Hits        11449    11449           
  Misses       7974     7974           
  Partials      847      847           

@alexanderbez alexanderbez marked this pull request as ready for review April 7, 2020 18:09
@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 7, 2020
@mergify mergify bot merged commit 7b21c54 into master Apr 7, 2020
@mergify mergify bot deleted the bez/finish-5905 branch April 7, 2020 18:32
@alexanderbez alexanderbez mentioned this pull request Apr 16, 2020
6 tasks
alexanderbez added a commit that referenced this pull request May 19, 2020
* Fix IncrementSequenceDecorator

* Update PR #

* Update godoc

* Add TestIncrementSequenceDecorator test
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants