Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add RegisterQueryService to AppModule #6336

Merged
merged 13 commits into from
Jun 6, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 3, 2020

ref: #5921

This updates AppModule to support GRPC queries via the RegisterQueryService method.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #6336 into master will increase coverage by 0.02%.
The diff coverage is 77.35%.

@@            Coverage Diff             @@
##           master    #6336      +/-   ##
==========================================
+ Coverage   55.72%   55.74%   +0.02%     
==========================================
  Files         450      450              
  Lines       27036    27053      +17     
==========================================
+ Hits        15067    15082      +15     
- Misses      10886    10888       +2     
  Partials     1083     1083              

@aaronc aaronc marked this pull request as ready for review June 4, 2020 18:19
@aaronc aaronc added R4R and removed WIP labels Jun 4, 2020
@aaronc aaronc marked this pull request as draft June 4, 2020 18:59
@aaronc aaronc marked this pull request as ready for review June 4, 2020 19:40
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 5, 2020
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tac0turtle
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2020

Command refresh: success

@mergify mergify bot merged commit 43947ca into master Jun 6, 2020
@mergify mergify bot deleted the aaronc/5921-grpc-app-module branch June 6, 2020 07:59
@aaronc aaronc mentioned this pull request Jun 10, 2020
11 tasks
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
@aaronc aaronc mentioned this pull request Jul 1, 2020
43 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Add RegisterQueryService to AppModule

* Update CHANGELOG.md

* Update CHANGELOG.md

* Wire up BaseApp, fix tests

* Add mock test

* add missing file

* Update types/module/module.go

* Update CHANGELOG.md

Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants