Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

store/rootmulti: add SimpleProofsFromMap #6481

Merged
merged 9 commits into from
Jun 23, 2020
Merged

Conversation

tac0turtle
Copy link
Member

Description

This PR brings simpleProofsFromMap to the sdk. This will be removed in 0.34 release of tendermint.

closes: #XXXX

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #6481 into master will increase coverage by 0.02%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
+ Coverage   56.31%   56.34%   +0.02%     
==========================================
  Files         470      470              
  Lines       28178    28232      +54     
==========================================
+ Hits        15869    15907      +38     
- Misses      11187    11200      +13     
- Partials     1122     1125       +3     

@tac0turtle tac0turtle force-pushed the marko/simpleProofsFromMap branch from f66e833 to b33003d Compare June 22, 2020 16:38
@tac0turtle tac0turtle marked this pull request as ready for review June 22, 2020 16:43
@tac0turtle tac0turtle added the R4R label Jun 22, 2020
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 22, 2020
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a Changelog entry? 🙏

@mergify mergify bot merged commit 67d079e into master Jun 23, 2020
@mergify mergify bot deleted the marko/simpleProofsFromMap branch June 23, 2020 08:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants