-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
x/staking: gRPC query Service #6490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6490 +/- ##
==========================================
+ Coverage 58.46% 58.65% +0.18%
==========================================
Files 511 512 +1
Lines 31047 31280 +233
==========================================
+ Hits 18151 18346 +195
- Misses 11543 11546 +3
- Partials 1353 1388 +35 |
This pull request introduces 3 alerts when merging bc3775f into 06d7dbe - view on LGTM.com new alerts:
|
This pull request introduces 9 alerts when merging e4738c7 into cb6c552 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging a485a85 into 51c35f4 - view on LGTM.com new alerts:
|
…dk into sahith/5921-staking-grpc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice gogoproto.nullable = false
is used a lot. Is this really needed? I'd rather minimize the usage of those annotations to things needed for backwards golang API compatibility. Is it to reduce nil
checks?
The main reason was to avoid dealing with nil data, but agree gogoproto extension usage should be minimised. Will ensure to keep it in mind for future work |
@sahith-narahari thanks. I think it's okay to leave it for now. I understand it would be a bigger refactor. |
Description
Ref: #5921
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer