Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

simulation unit tests: cosmetic changes #6800

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

dauTT
Copy link
Contributor

@dauTT dauTT commented Jul 20, 2020

Description

With this last PR which is meant to clean few test files, I believe we can close issue #5007


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #6800 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6800   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files         514      514           
  Lines       31635    31635           
=======================================
  Hits        19119    19119           
  Misses      11049    11049           
  Partials     1467     1467           

@alexanderbez alexanderbez merged commit efa73c7 into cosmos:master Jul 20, 2020
@dauTT dauTT deleted the issue-5007 branch July 20, 2020 20:24
chengwenxi pushed a commit to irisnet/cosmos-sdk that referenced this pull request Jul 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants