Add failing address to multisig validation #8518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
aaronc,
alessio and
alexanderbez
as code owners
zmanian
reviewed
Feb 5, 2021
x/auth/client/cli/tx_multisign.go
Outdated
| @@ -125,7 +125,7 @@ func makeMultiSignCmd() func(cmd *cobra.Command, args []string) (err error) { | |||
| for _, sig := range sigs { | |||
| err = signing.VerifySignature(sig.PubKey, signingData, sig.Data, txCfg.SignModeHandler(), txBuilder.GetTx()) | |||
| if err != nil { | |||
| return fmt.Errorf("couldn't verify signature: %w", err) | |||
| return fmt.Errorf("couldn't verify signature for address %s", sig.PubKey.Address()) | |||
There was a problem hiding this comment.
addr, _ := sdktypes.AccAddressFromHex(stdSig.PubKey.Address().String())
return fmt.Errorf("couldn't verify signature for address %s", addr)
There was a problem hiding this comment.
Needs an import added too
sdktypes "github.com/cosmos/cosmos-sdk/types"
amaury1093
reviewed
Feb 12, 2021
alexanderbez
approved these changes
Feb 14, 2021
| @@ -125,7 +125,8 @@ func makeMultiSignCmd() func(cmd *cobra.Command, args []string) (err error) { | |||
| for _, sig := range sigs { | |||
| err = signing.VerifySignature(sig.PubKey, signingData, sig.Data, txCfg.SignModeHandler(), txBuilder.GetTx()) | |||
| if err != nil { | |||
| return fmt.Errorf("couldn't verify signature: %w", err) | |||
| addr, _ := sdk.AccAddressFromHex(sig.PubKey.Address().String()) | |||
There was a problem hiding this comment.
Nit you can drop the .String() as the %s formatter will automatically do this.
amaury1093
approved these changes
Feb 18, 2021
…sdk into jack/multisig-index
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR helps users of multisig wallets debug signature issues. cc @zmanian for the hat tip