Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ADR-019/020 cleanups: HybridCodec, Pubkey #8683

Merged
merged 7 commits into from
Feb 25, 2021
Merged

Conversation

amaury1093
Copy link
Contributor

Description

ref: initially #8053


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@amaury1093 amaury1093 added the T: ADR An issue or PR relating to an architectural decision record label Feb 24, 2021
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one suggestion - AFAIU Amino is not used for fallback, but for legacy use cases.

@amaury1093 amaury1093 changed the title ADR-019 cleanups re HybridCodec ADR-019/020 cleanups: HybridCodec, Pubkey Feb 24, 2021
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for making this change.

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 25, 2021
@mergify mergify bot merged commit 19e79e0 into master Feb 25, 2021
@mergify mergify bot deleted the am/8053-adr019-cleanups branch February 25, 2021 15:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: ADR An issue or PR relating to an architectural decision record
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants