This repository was archived by the owner on Nov 30, 2021. It is now read-only.
keys: fix privkey derivation #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
commented
Sep 29, 2020
| @@ -58,27 +58,37 @@ func EthermintKeygenFunc(bz []byte, algo keys.SigningAlgo) (tmcrypto.PrivKey, er | |||
| return PrivKeySecp256k1(bz), nil | |||
| } | |||
|
|
|||
| func DeriveSecp256k1(mnemonic, bip39Passphrase, _ string) ([]byte, error) { | |||
There was a problem hiding this comment.
hdpath wasn't being used to derive the key
Codecov Report
@@ Coverage Diff @@
## development #554 +/- ##
===============================================
- Coverage 70.72% 70.71% -0.02%
===============================================
Files 42 42
Lines 2333 2339 +6
===============================================
+ Hits 1650 1654 +4
- Misses 540 541 +1
- Partials 143 144 +1
Continue to review full report at Codecov.
|
fedekunze
commented
Sep 29, 2020
|
|
||
| path := hdwallet.MustParseDerivationPath(hdPath) | ||
|
|
||
| account, err := wallet.Derive(path, false) |
There was a problem hiding this comment.
I used this library to test the correctness with ethereum
noot
approved these changes
Sep 29, 2020
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.