Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Circle CI update #69

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Circle CI update #69

merged 1 commit into from
Jul 11, 2019

Conversation

austinabell
Copy link

Previously the CI included linting in the build process, which was annoying and misleading if the linter failed. I don't care if we don't merge this in, but it would be nice :)

This change separates linting into its own workflow.

@austinabell austinabell requested a review from ansermino July 9, 2019 22:38
Copy link

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

(Note: If we wanted to separate it even further we could use golangci.org, its basically pre-configured CI for all the golangci tools. That way testing and formatting/linting happen simultaneously)

@austinabell austinabell merged commit 73cf6d9 into development Jul 11, 2019
@ansermino ansermino deleted the austin/circlecichanges branch July 11, 2019 17:13
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants