This repository was archived by the owner on Nov 30, 2021. It is now read-only.
Minor fixes #94
Merged
Minor fixes #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM given the ToInt lint fix from the type change (can just remove the ToInt function) |
austinabell
reviewed
Sep 20, 2019
x/evm/querier.go
Outdated
| } | ||
|
|
||
| return res, nil | ||
| } | ||
|
|
||
| func queryBlockNumber(ctx sdk.Context, keeper Keeper) ([]byte, sdk.Error) { | ||
| num := ctx.BlockHeight() | ||
| bnRes := types.QueryResBlockNumber{Number: big.NewInt(num)} | ||
| res, err := codec.MarshalJSONIndent(keeper.cdc, bnRes) | ||
| hexBig := hexutil.Uint64(num) |
There was a problem hiding this comment.
Small nitpick but confusing name since it's a hexutil uint. Also, the type that is being received on the RPC api is just a uint64, reason for marshalling it as this type?
There was a problem hiding this comment.
I see hexutil.Uint64 all the way through: https://github.com/ChainSafe/ethermint/blob/9812df303517a9324710585cbabbba196f066bd7/rpc/eth_api.go#L91
There was a problem hiding this comment.
ah, my bad actually (was looking at old type I think), if you do another commit though to change hexBig to hexUint or something more accurate would be great, but fine with this
austinabell
suggested changes
Sep 20, 2019
austinabell
approved these changes
Sep 23, 2019
Merged
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the return types for the eth_ API and simplifies the types used in queries.
hexutil), as the API is very specific about formatting.