refactor: add comprehensive tests for previously missing routes and refactor test. #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glnro
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
mmulji-ic
approved these changes
Jan 30, 2023
mmulji-ic
added a commit
that referenced
this pull request
Jan 30, 2023
* Reintroduce missing code for rest endpoint wiring * Fix gofumpt * e2e test to check if endpoints are available * Ran linter/formater * Refactor and add comprehensive tests for missing routes (#2094) * Fixed var -> const definition --------- Co-authored-by: lg <lauren@interchain.io> Co-authored-by: lg <8335464+glnro@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Reintroduce missing code for rest endpoint wiring * Fix gofumpt * e2e test to check if endpoints are available * Ran linter/formater * Refactor and add comprehensive tests for missing routes (#2094) * Fixed var -> const definition --------- Co-authored-by: lg <lauren@interchain.io> Co-authored-by: lg <8335464+glnro@users.noreply.github.com> (cherry picked from commit 690f167)
mergify bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Reintroduce missing code for rest endpoint wiring * Fix gofumpt * e2e test to check if endpoints are available * Ran linter/formater * Refactor and add comprehensive tests for missing routes (#2094) * Fixed var -> const definition --------- Co-authored-by: lg <lauren@interchain.io> Co-authored-by: lg <8335464+glnro@users.noreply.github.com> (cherry picked from commit 690f167)
mmulji-ic
added a commit
that referenced
this pull request
Jan 30, 2023
* Reintroduce missing code for rest endpoint wiring * Fix gofumpt * e2e test to check if endpoints are available * Ran linter/formater * Refactor and add comprehensive tests for missing routes (#2094) * Fixed var -> const definition --------- Co-authored-by: lg <lauren@interchain.io> Co-authored-by: lg <8335464+glnro@users.noreply.github.com> (cherry picked from commit 690f167) Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com>
mmulji-ic
added a commit
that referenced
this pull request
Jan 30, 2023
* Reintroduce missing code for rest endpoint wiring * Fix gofumpt * e2e test to check if endpoints are available * Ran linter/formater * Refactor and add comprehensive tests for missing routes (#2094) * Fixed var -> const definition --------- Co-authored-by: lg <lauren@interchain.io> Co-authored-by: lg <8335464+glnro@users.noreply.github.com> (cherry picked from commit 690f167) Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves upon #2080 by including additional tests that cover all of the missing REST configurations that were previously deleted as reported in #2074 .