Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore!: set the min evidence height for neutron-1 and stride-1 #2821

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Nov 17, 2023

Description

Closes: NA

Set the min evidence height for neutron-1 and stride-1 in the v14 upgrade handler.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpoke mpoke merged commit 1bb6bc9 into main Nov 20, 2023
@mpoke mpoke deleted the marius/min-evidence-height branch November 20, 2023 08:51
mpoke added a commit that referenced this pull request Nov 21, 2023
mpoke added a commit that referenced this pull request Nov 21, 2023
* bump ICS to v2.4.0-lsm

* add changelog entries and update v14.0.0 section

* add changelog entry for #2821
mergify bot pushed a commit that referenced this pull request Nov 21, 2023
* bump ICS to v2.4.0-lsm

* add changelog entries and update v14.0.0 section

* add changelog entry for #2821

(cherry picked from commit b3b4c15)
mpoke added a commit that referenced this pull request Nov 21, 2023
* bump ICS to v2.4.0-lsm

* add changelog entries and update v14.0.0 section

* add changelog entry for #2821

(cherry picked from commit b3b4c15)

Co-authored-by: Marius Poke <marius.poke@posteo.de>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants