Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

R4R Update for client generalization #31

Merged
merged 10 commits into from
Jun 5, 2019
Merged

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented May 31, 2019

REF cosmos/cosmos-sdk#4451

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 60%.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files           4        4           
  Lines         197      197           
=======================================
  Hits          111      111           
  Misses         83       83           
  Partials        3        3

@alexanderbez alexanderbez merged commit 0846cc5 into master Jun 5, 2019
@alexanderbez alexanderbez deleted the rigel/client-mm branch June 5, 2019 23:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants