Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added config.yml for Starport #535

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Added config.yml for Starport #535

merged 1 commit into from
Jan 11, 2021

Conversation

fadeev
Copy link
Contributor

@fadeev fadeev commented Jan 11, 2021

Closes: #519

Description

Added config.yml required for starport serve to work.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fadeev fadeev marked this pull request as ready for review January 11, 2021 18:18
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #535 (f1dac2a) into main (98b2ade) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   11.58%   11.58%           
=======================================
  Files           8        8           
  Lines         673      673           
=======================================
  Hits           78       78           
  Misses        586      586           
  Partials        9        9           

@fadeev
Copy link
Contributor Author

fadeev commented Jan 11, 2021

For context, the file is called config.yml (and not, say, starport.yml), because it includes tool-independent configurations, like accounts and genesis that could potentially be used by other tools and/or scripts. It's just a non-opinionated way to declaratively describe parameters for development.

@fedekunze fedekunze merged commit b45c236 into main Jan 11, 2021
@fedekunze fedekunze deleted the starport-config branch January 11, 2021 22:42
shahankhatch pushed a commit that referenced this pull request Jan 18, 2021
shahankhatch pushed a commit that referenced this pull request Jan 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starport support
3 participants