You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's probably desirable to know which address is receiving the fee. Instead of batching up the total fees distributed, each time a non refund fee is distributed, emit a distribution event which includes the total amount and the address being distributed to
Background information shared by @adizere to inform priority:
it would be good if this can be done (not released, only drafted in a PR so we can use it in simd) as soon as possible -- if possible December or January, it would be amazing!
for context, we're doing a demo for relayer operators demonstrating the usefulness of fees, and this feature seems necessary we're still experimenting with things so we might have additional feedback by the way
It's probably desirable to know which address is receiving the fee. Instead of batching up the total fees distributed, each time a non refund fee is distributed, emit a distribution event which includes the total amount and the address being distributed to
Given this comment by @colin-axner I think the easiest will be to call EmitDistributeFeeEvent inside distributeFee in the case when the call to k.bankKeeper.SendCoinsFromModuleToAccount does not return an error.
Summary
Using the event system, an external user should be able to determine the amount of fees paid via ics29. Add an event upon distribution of fees.
Problem Definition
We currently only emit total fees escrowed (which doesn't indicate total fees paid)
Proposal
Add a function
EmitDistributeFeeEvent
to events.goWithin
distributeFeeOnAcknowledgement
keep track of the total fees not refunded. Pass the total amount intoEmitDistributeFeeEvent
Within
distributeFeeOnTimeoutEvent
, callEmitDistributeFeeEvent
using thetimeoutFee
For Admin Use
The text was updated successfully, but these errors were encountered: