Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding metrics related to ICS29 fees #2945

Closed
2 of 7 tasks
Tracked by #2788 ...
ljoss17 opened this issue Dec 13, 2022 · 1 comment
Closed
2 of 7 tasks
Tracked by #2788 ...

Adding metrics related to ICS29 fees #2945

ljoss17 opened this issue Dec 13, 2022 · 1 comment
Assignees
Labels
O: ics29-fee Objective: Fee middleware support
Milestone

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Dec 13, 2022

Summary

Retrieve data on ICS29 fees which have been distributed.

Note that this work, which depends on Tendermint multi-version support, is currently branched off of the mikhail/multi-version-tendermint branch. The last thing to do will be to merge the metrics into main once multi-version support has been merged into Hermes.

Problem Definition

At Hermes v1.1 in order to have an idea of how much fees have been paid to relayers via ICS29, a user would need to query the balances and compute the difference while taking into account the gas paid.

Proposal

When events with fee distribution information will be emitted, cosmos/ibc-go#2847, Hermes should retrieve and display this information (e.g. adding new metrics).

Acceptance Criteria

  • Hermes displays useful metrics regarding fees distributed via ICS29
  • Merge into main once the mikhail/multi-version-tendermint branch is merged

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@seanchen1991 seanchen1991 moved this to 📋 Backlog in Hermes Dec 13, 2022
@seanchen1991 seanchen1991 moved this from 📋 Backlog to 🆕 New in Hermes Dec 13, 2022
@seanchen1991 seanchen1991 added the O: ics29-fee Objective: Fee middleware support label Dec 14, 2022
@seanchen1991 seanchen1991 added this to the v1.3 milestone Dec 14, 2022
@adizere
Copy link
Member

adizere commented Jan 9, 2023

We'll test with cosmos/ibc-go#2975

@seanchen1991 seanchen1991 removed this from the v1.3 milestone Jan 31, 2023
@ljoss17 ljoss17 self-assigned this Feb 6, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🛑 Blocked in Hermes Feb 6, 2023
@seanchen1991 seanchen1991 added this to the v1.4 milestone Feb 6, 2023
@seanchen1991 seanchen1991 moved this from 🛑 Blocked to 🏗 In progress in Hermes Feb 13, 2023
@seanchen1991 seanchen1991 moved this from 🏗 In progress to 👀 In review in Hermes Feb 13, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Hermes Feb 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
O: ics29-fee Objective: Fee middleware support
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants