Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Build 08-wasm with libwasmvm linking disabled #5903

Closed
3 tasks
damiannolan opened this issue Feb 26, 2024 · 3 comments · Fixed by #5923
Closed
3 tasks

Build 08-wasm with libwasmvm linking disabled #5903

damiannolan opened this issue Feb 26, 2024 · 3 comments · Fixed by #5923
Assignees
@damiannolan
Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Rollkit integration

Comments

@damiannolan
Copy link
Contributor

Summary

Similarly to x/wasm add a NewKeeper constructor func for 08-wasm which panics when used. This should be guarded by the: //go:build !cgo build flags.

Additionally, we can add //go:build csgo for the keeper file which already exists.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Feb 26, 2024
@damiannolan damiannolan added this to the v9.0.0 milestone Feb 26, 2024
@damiannolan damiannolan moved this to Todo 🏃 in ibc-go Feb 26, 2024
@damiannolan
Copy link
Contributor Author

This should allow users to consume types without needing the entire CGO stack for wasmvm.

@chatton chatton assigned chatton and unassigned chatton Feb 28, 2024
@damiannolan damiannolan self-assigned this Mar 4, 2024
@damiannolan damiannolan moved this from Todo 🏃 to In progress 👷 in ibc-go Mar 4, 2024
@damiannolan damiannolan mentioned this issue Mar 4, 2024
Merged
9 tasks
@damiannolan
Copy link
Contributor Author

We have chosen to use a separate build tag ibcwasm_novm instead of completely disabling cgo. It's possible that a binary may need cgo dependencies as well as wanting 08-wasm types only available to them

@damiannolan damiannolan changed the title Build 08-wasm without cgo option Build 08-wasm with libwasmvm linking disabled Mar 20, 2024
@damiannolan
Copy link
Contributor Author

Renamed the issue to reflect the desired behaviour

@damiannolan damiannolan moved this from In progress 👷 to In review 👀 in ibc-go Mar 25, 2024
@crodriguezvega crodriguezvega moved this from In review 👀 to On hold ❌ in ibc-go Apr 1, 2024
@github-project-automation github-project-automation bot moved this from On hold ❌ to Done 🥳 in ibc-go Apr 2, 2024
@mergify mergify bot mentioned this issue Jun 10, 2024
Merged
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@damiannolan damiannolan

Labels
08-wasm type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
Rollkit integration
Development

Successfully merging a pull request may close this issue.

imp: adding 08-wasm build opts with libwasmvm linking disabled cosmos/ibc-go
2 participants
@damiannolan @chatton