Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add non cgo build #1166

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

jhernandezb
Copy link
Contributor

@jhernandezb jhernandezb commented Jan 21, 2023

This is a replacement for #1162 which now only requires a change in the keeper.

The original POC required the cli to be modified because wasmvm.LibwasmvmVersion() wasn't handling the cgo,no_cgo but now it does by returning an error.

@jhernandezb jhernandezb requested a review from alpe as a code owner January 21, 2023 01:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Merging #1166 (9c91d42) into wasmvm_1143rc1 (dc10fad) will not change coverage.
The diff coverage is 92.30%.

Impacted file tree graph

@@               Coverage Diff               @@
##           wasmvm_1143rc1    #1166   +/-   ##
===============================================
  Coverage           57.46%   57.46%           
===============================================
  Files                  53       54    +1     
  Lines                7408     7408           
===============================================
  Hits                 4257     4257           
  Misses               2853     2853           
  Partials              298      298           
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.52% <ø> (-0.20%) ⬇️
x/wasm/keeper/keeper_cgo.go 92.30% <92.30%> (ø)

Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaces #1162
Nice, thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants