Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run ica genesis/types tests. #4193

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Run ica genesis/types tests. #4193

merged 2 commits into from
Jul 28, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

They weren't executing.

closes: #XXXX

Commit Message / Changelog Entry

nit: Run ica genesis/types tests.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@codecov-commenter
Copy link

Codecov Report

Merging #4193 (e4c688f) into main (585e56b) will increase coverage by 0.59%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4193      +/-   ##
==========================================
+ Coverage   78.86%   79.45%   +0.59%     
==========================================
  Files         188      188              
  Lines       12994    12994              
==========================================
+ Hits        10248    10325      +77     
+ Misses       2317     2240      -77     
  Partials      429      429              

see 1 file with indirect coverage changes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

glad they pass 😅

@DimitrisJim
Copy link
Contributor Author

glad they pass 😅

you'd see a DM and not a PR if they didn't 😄

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@DimitrisJim DimitrisJim merged commit 730aa16 into main Jul 28, 2023
@DimitrisJim DimitrisJim deleted the run-ica-genesis-tests branch July 28, 2023 04:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants