Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use collections contains when checking client type is in allow list #4196

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega added the type: code hygiene Clean up code but without changing functionality or interfaces label Jul 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #4196 (03531f2) into main (730aa16) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4196      +/-   ##
==========================================
- Coverage   79.45%   79.45%   -0.01%     
==========================================
  Files         188      188              
  Lines       12994    12990       -4     
==========================================
- Hits        10325    10321       -4     
  Misses       2240     2240              
  Partials      429      429              
Files Changed Coverage Δ
modules/core/02-client/types/params.go 100.00% <100.00%> (ø)

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! found more instances of this elsewhere too

@crodriguezvega crodriguezvega merged commit 4e1e594 into main Jul 28, 2023
@crodriguezvega crodriguezvega deleted the carlos/use-collections-contains-client-params branch July 28, 2023 06:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants