Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove dogsled, clean up .golangci unused settings. #4223

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

Remove the dogsled feature as discussed in linter call, also remove some unnecessary setting for linters we don't use anymore.

closes: #XXXX

Commit Message / Changelog Entry

chore: remove dogled, settings for linters not used.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DimitrisJim DimitrisJim enabled auto-merge (squash) August 2, 2023 09:53
@DimitrisJim DimitrisJim merged commit c0c6278 into main Aug 2, 2023
@DimitrisJim DimitrisJim deleted the jim/remove-cruft branch August 2, 2023 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants