cosmos · colin-axner · Aug 7, 2023 · Jul 27, 2023 · Jul 27, 2023 · Jul 27, 2023
diff --git a/.github/compatibility-test-matrices/main/client-chain-a.json b/.github/compatibility-test-matrices/main/client-chain-a.json
@@ -20,6 +20,7 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
+    "TestClient_Update_Misbehaviour",
     "TestAllowedClientsParam"
   ],
   "relayer-type": [

diff --git a/.github/compatibility-test-matrices/main/client-chain-b.json b/.github/compatibility-test-matrices/main/client-chain-b.json
@@ -20,6 +20,7 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
+    "TestClient_Update_Misbehaviour",
     "TestAllowedClientsParam"
   ],
   "relayer-type": [

diff --git a/.github/compatibility-test-matrices/main/ica-chain-a.json b/.github/compatibility-test-matrices/main/ica-chain-a.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/main/ica-chain-b.json b/.github/compatibility-test-matrices/main/ica-chain-b.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/client-chain-a.json b/.github/compatibility-test-matrices/release-v6.1.x/client-chain-a.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v6.1.x/client-chain-b.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-a.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-b.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/client-chain-a.json b/.github/compatibility-test-matrices/release-v6.2.x/client-chain-a.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v6.2.x/client-chain-b.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-a.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-b.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/client-chain-a.json b/.github/compatibility-test-matrices/release-v7.2.x/client-chain-a.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v7.2.x/client-chain-b.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-a.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-b.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/client-chain-a.json b/.github/compatibility-test-matrices/release-v7.3.x/client-chain-a.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v7.3.x/client-chain-b.json
@@ -19,7 +19,8 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour"
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-a.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-b.json
@@ -14,7 +14,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/unreleased/client.json b/.github/compatibility-test-matrices/unreleased/client.json
@@ -27,7 +27,9 @@
     "TestClientTestSuite"
   ],
   "test": [
-    "TestClientUpdateProposal_Succeeds"
+    "TestClientUpdateProposal_Succeeds",
+    "TestClient_Update_Misbehaviour",
+    "TestAllowedClientsParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/unreleased/ica.json b/.github/compatibility-test-matrices/unreleased/ica.json
@@ -17,7 +17,9 @@
   "test": [
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
-    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA"
+    "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
+    "TestControllerEnabledParam",
+    "TestHostEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/workflows/golangci.yml b/.github/workflows/golangci.yml
@@ -22,5 +22,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3.6.0
         with:
-          version: v1.53.1
+          version: v1.53.3
           args: --timeout 5m
diff --git a/.golangci.yml b/.golangci.yml
@@ -5,7 +5,6 @@ run:
 linters:
   disable-all: true
   enable:
-    - dogsled
     - exportloopref
     - errcheck
     - gci
@@ -20,32 +19,24 @@ linters:
     - nakedret
     - staticcheck
     - thelper
+    - typecheck
     - stylecheck
     - revive
     - typecheck
+    - tenv
     - unconvert
     - unused
     - misspell
 
 issues:
   exclude-rules:
-    - text: 'unused-parameter'
+    - text: 'differs only by capitalization to method'
       linters:
         - revive
-    - text: 'SA1019:'
-      linters:
-        - staticcheck
     - text: 'Use of weak random number generator'
       linters:
         - gosec
-    - text: 'ST1003:'
-      linters:
-        - stylecheck
-    # FIXME: Disabled until golangci-lint updates stylecheck with this fix:
-    # https://github.com/dominikh/go-tools/issues/389
-    - text: 'ST1016:'
-      linters:
-        - stylecheck
+
   max-issues-per-linter: 10000
   max-same-issues: 10000
 
@@ -61,17 +52,57 @@ linters-settings:
       - prefix(github.com/cometbft/cometbft)
       - prefix(github.com/cosmos/ibc-go)
     custom-order: true
-  dogsled:
-    max-blank-identifiers: 3
-  maligned:
-    # print struct with more effective memory layout or not, false by default
-    suggest-new: true
-  nolintlint:
-    allow-unused: false
-    allow-leading-space: true
-    require-explanation: false
-    require-specific: false
   revive:
+    enable-all-rules: true
+    # Do NOT whine about the following, full explanation found in:
+    # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#description-of-available-rules
     rules:
+      - name: use-any
+        disabled: true
       - name: if-return
         disabled: true
+      - name: max-public-structs
+        disabled: true
+      - name: cognitive-complexity
+        disabled: true
+      - name: argument-limit
+        disabled: true
+      - name: cyclomatic
+        disabled: true
+      - name: file-header
+        disabled: true
+      - name: function-length
+        disabled: true
+      - name: function-result-limit
+        disabled: true
+      - name: line-length-limit
+        disabled: true
+      - name: flag-parameter
+        disabled: true
+      - name: add-constant
+        disabled: true
+      - name: empty-lines
+        disabled: true
+      - name: banned-characters
+        disabled: true
+      - name: deep-exit
+        disabled: true
+      - name: confusing-results
+        disabled: true
+      - name: unused-parameter
+        disabled: true
+      - name: modifies-value-receiver
+        disabled: true
+      - name: early-return
+        disabled: true
+      - name: confusing-naming
+        disabled: true
+      - name: defer
+        disabled: true
+      - name: unhandled-error
+        disabled: false
+        arguments:
+          - 'fmt.Printf'
+          - 'fmt.Print'
+          - 'fmt.Println'
+          - 'myFunction'
diff --git a/docs/.vuepress/config.js b/docs/.vuepress/config.js
@@ -284,6 +284,11 @@ module.exports = {
                   directory: false,
                   path: "/apps/interchain-accounts/parameters.html",
                 },
+                {
+                  title: "Tx Encoding",
+                  directory: false,
+                  path: "/apps/interchain-accounts/tx-encoding.html",
+                },
                 {
                   title: "Client",
                   directory: false,
@@ -314,7 +319,7 @@ module.exports = {
                       directory: false,
                       path: "/apps/interchain-accounts/legacy/keeper-api.html",
                     },
-                  ]
+                  ],
                 },
               ],
             },
@@ -425,7 +430,7 @@ module.exports = {
                   directory: false,
                   path: "/ibc/light-clients/setup.html",
                 },
-              ]
+              ],
             },
             {
               title: "Localhost",

diff --git a/docs/apps/interchain-accounts/active-channels.md b/docs/apps/interchain-accounts/active-channels.md
@@ -1,5 +1,5 @@
 <!--
-order: 8
+order: 9
 -->
 
 # Understanding Active Channels