Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: add additional docs on edge case channel upgradability scenarios #5735

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

colin-axner
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@colin-axner colin-axner added docs Improvements or additions to documentation channel-upgradability Channel upgradability feature priority PRs that need prompt reviews labels Jan 25, 2024
@colin-axner colin-axner added this to the 04-channel upgrades RC milestone Jan 25, 2024
Copy link
Member

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/docs/01-ibc/06-channel-upgrades.md Outdated Show resolved Hide resolved
crodriguezvega and others added 2 commits January 26, 2024 11:55
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
@crodriguezvega crodriguezvega merged commit 16082d6 into main Jan 26, 2024
19 checks passed
@crodriguezvega crodriguezvega deleted the colin/chanupgrade-edgecase-docs branch January 26, 2024 13:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
channel-upgradability Channel upgradability feature docs Improvements or additions to documentation priority PRs that need prompt reviews
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants